Kaufland website import

8 zpráv
Zpět na přehled

Kaufland website import

8 zpráv MMM 3 účastníků 4 min čtení
  1. Mateusz Konieczny matkoniecz na tutanota.com #m34dece
    I want to propose importing Kaufland Websites in Czech Republic, using data on their first-party website, via All The Places dataset. The tricky part is that due to my mistake import mostly already happened. I am sorry for that, that is obviously a wrong order. See https://community.openstreetmap.org/t/sorry-for-a-bot-edit-escaping-its-supposed-borders-adding-website-tags/135087 You can see affected objects on https://wiki.openstreetmap.org/wiki/Mechanical_Edits/Mateusz_Konieczny_-_bot_account/Czech_Republic_Kaufland If import will be rejected or not accepted, I will revert all such edits. If import will be accepted I will post changeset comments on relevant changesets explaining that it was in the end reviewed and accepted. And make future edits based on new matches, once they will be found. This is especially likely for newly opened shops. more detail is available at https://wiki.openstreetmap.org/wiki/Mechanical_Edits/Mateusz_Konieczny_-_bot_account/import_Kaufland_websites_in_Czech_Republic Please, comment if you either support this import or disagree with it.
  2. mahdi1234 mahdi1234 na centrum.cz #m1c1695
    Hi, I think it is well prepared and as discussed on chat also having multiple QA checks before making any changes. Thus I agree. mahdi
  3. martin-kokos martin-kokos na protonmail.com #m19b6ff
    I've looked into the documentation, data processing code and tests, and I am satisfied with the rigor you've put into. Thank you. I've manually checked 20 entities at random from the list on the wiki and I did not see any issues. I agree with keeping the changes. Some notes though; - the report doesn't seem to be correct on Kaufland, so that's a bit deceiving - https://matkoniecz.codeberg.page/improving_openstreetmap_using_alltheplaces_dataset/areas/50/14_index.html - I'd like to see a plaintext diff since osm.org and osmcha are not made for viewing sets of changesets. (not aware of a good tool) or script output that logs the changes being made - You are brave in using spaces in bot's name :) - I am happy you've included a QA section Martin Sent with [Proton Mail] secure email.
  4. Mateusz Konieczny matkoniecz na tutanota.com #m6c5395
    I've looked into the documentation, data processing code and tests, and I am satisfied with the rigor you've put into. Thank you.
    Thanks for replies and I am obviously happy about response being positive so far :)
    the report doesn't seem to be correct on Kaufland, so that's a bit deceiving - > https://matkoniecz.codeberg.page/improving_openstreetmap_using_alltheplaces_dataset/areas/50/14_index.html
    which part seems to not be correct? note that my processing tries to make false negatives (avoid suggestions or import) rather than false positives
    I'd like to see a plaintext diff since osm.org and osmcha are not made for viewing sets of changesets. (not aware of a good tool) or script output that logs the changes being made
    would plaintext list of tags modified would be good enough? ( locations of nodes were not changed by bot, nodes were not created, nodes were not added nor removed from ways, relation roles were not modified or added or removed etc)
    You are brave in using spaces in bot's name :)
    This worked well, though code sits in directory path without any spaces :)
  5. martin-kokos martin-kokos na protonmail.com #m9da292
    Sorry, regarding the report, I misunderstood, it shows only missing, not all matched which I was expecting. I think all the numbers you§d put on a Venn diagram would be useful to show. Yes, just plaintext. Something that could be checked or grepped without having to open up each node an a map, eg. n123456: +website:asdfg +opening_hours:12-34. I don't know if codeberg has runners but it would be could to have the script run as "action" and output log there and automatically saved and accessible. Just an idea - don't want to push you into some workflow that may not be practical in reality. Sent with [Proton Mail] secure email.
  6. Mateusz Konieczny matkoniecz na tutanota.com #m57f63b
    https://pastebin.com/axchy8yw should have listing you requested if any other data is needed - feel free to ask!
  7. martin-kokos martin-kokos na protonmail.com #mb5cebf
    Thanks a lot, looks good. I think it would be good to have this kind of log for any kind of automated edit. Thanks again Mateusz for what you do. Sent with [Proton Mail] secure email.
  8. Mateusz Konieczny matkoniecz na tutanota.com #m6214bd
    though note "And make future edits based on new matches, once they will be found" part - this is obviously harder to predict as for example depends on where new shops will be mapped (including some not yet existing!) and may also depend on improvements in my matching code which may become able to handle some POIs not edited before
Napsat odpověď e-mailem… Odpovědět

Otevře váš e-mailový klient. Odpovědi pak sledujte zde na webu.